Add menu support to folder-contents breadcrumb for long navigation titles#7640
Add menu support to folder-contents breadcrumb for long navigation titles#7640
Conversation
|
@sneridagh can you please review if I am doing everything right? we need talk about the css changes. 
|
iFlameing
changed the title
|
|
||
| const navigate = (to, options = {}) => { | ||
| if (options.replace) { | ||
| history.replace(to); |
There was a problem hiding this comment.
To support replace instead of push behaviour.
There was a problem hiding this comment.
in Link of react-aria-component you can pass options like replace and I want to support it that's why.
There was a problem hiding this comment.
Is it actually used by the breadcrumbs? If not it should be in its own PR with its own entry in the release notes.
There was a problem hiding this comment.
@davisagli Yes, if we don’t implement it in this PR, then folder-content navigation will not work.
There was a problem hiding this comment.
if you see the pr I have added the routercontext so that client side navigation work for Link components of react-aria-components.
There was a problem hiding this comment.
There was a problem hiding this comment.
@iFlameing Please add an entry of its own in this PR mentioning the new provider and what's for, I think the change is worth the effort.
|
I am busy, that's why I am not working on this. I will update it as soon as i get time. |
3 participants
… title
Caution
The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #
If your pull request includes changes to the documentation—either in narrative documentation, Storybook, or configuration—then a pull request preview will be generated and a link will populate in the description of your pull request below.
By clicking that link, you can use the visual diff menu in the upper right corner to navigate to pages that have changes, then display the diff by checking the
Show diffcheckbox.