Skip to content

Update id collision checks with missing checks from CMFPlone.#109

Merged
thet merged 1 commit intomainfrom
thet/check-for-collision-update
Feb 24, 2026
Merged

Update id collision checks with missing checks from CMFPlone.#109
thet merged 1 commit intomainfrom
thet/check-for-collision-update

Conversation

@thet
Copy link
Member

@thet thet commented Feb 23, 2026

Some of the checks in utils._check_for_collision or erronous. These checks were updated with the original checks from CMFPlone. The tests depend on a fully set-up site and remain in CMFPlone.

While working on plone/Products.CMFPlone#4282 the failing tests revealed an incomplete _check_for_collision method. Before PR 4282 the cmfplone tests were importing the _check_for_collision method from CMFPlone itself which was nowhere used anymore except in the tests, so the failure in plone.base.utils._check_for_collision did not surface.
This PR and the one in plone/Products.CMFPlone#4282 fixes that.

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet thet requested review from ale-rt, davisagli and jensens February 23, 2026 16:08
@thet thet force-pushed the thet/check-for-collision-update branch from a8ae6d2 to ce81c49 Compare February 23, 2026 16:12
Some of the checks in `utils._check_for_collision` or erroneous. These checks
were updated with the original checks from CMFPlone. The tests depend on a
fully set-up site and remain in CMFPlone.
@thet thet force-pushed the thet/check-for-collision-update branch from ce81c49 to cf2dc62 Compare February 23, 2026 16:14
@thet thet requested review from petschki and removed request for jensens February 23, 2026 16:23
@thet thet merged commit 4c134c0 into main Feb 24, 2026
12 checks passed
@thet thet deleted the thet/check-for-collision-update branch February 24, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants