Update id collision checks with missing checks from CMFPlone.#109
Merged
Conversation
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
a8ae6d2 to
ce81c49
Compare
8 tasks
Some of the checks in `utils._check_for_collision` or erroneous. These checks were updated with the original checks from CMFPlone. The tests depend on a fully set-up site and remain in CMFPlone.
ce81c49 to
cf2dc62
Compare
davisagli
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the checks in
utils._check_for_collisionor erronous. These checks were updated with the original checks from CMFPlone. The tests depend on a fully set-up site and remain in CMFPlone.While working on plone/Products.CMFPlone#4282 the failing tests revealed an incomplete
_check_for_collisionmethod. Before PR 4282 the cmfplone tests were importing the_check_for_collisionmethod from CMFPlone itself which was nowhere used anymore except in the tests, so the failure in plone.base.utils._check_for_collision did not surface.This PR and the one in plone/Products.CMFPlone#4282 fixes that.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #