Skip to content

Remove moved utility functions#4282

Merged
thet merged 1 commit intomasterfrom
thet/remove-moved
Feb 27, 2026
Merged

Remove moved utility functions#4282
thet merged 1 commit intomasterfrom
thet/remove-moved

Conversation

@thet
Copy link
Member

@thet thet commented Feb 23, 2026

Remove utility functions which were already moved to plone.base.

The following utility functions were already moved to plone.base.utils and are
removed from CMFPlone:

- `transaction_note`
- `check_id`
- `_check_for_collision`

Requires: plone/plone.base#109

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet
Copy link
Member Author

thet commented Feb 24, 2026

@mauritsvanrees not urgent at all, but if you find the time could you please again do a release of plone.base? This already merged PR needs to go into a release, so that this PR here can get green.

The following utility functions were already moved to plone.base.utils and are
removed from CMFPlone:

- `transaction_note`
- `check_id`
- `_check_for_collision`
@thet thet force-pushed the thet/remove-moved branch from a61c7ce to f503157 Compare February 24, 2026 10:50
@mauritsvanrees
Copy link
Member

@mauritsvanrees not urgent at all, but if you find the time could you please again do a release of plone.base? This already merged PR needs to go into a release, so that this PR here can get green.

@thet Done.

@thet thet merged commit 9c77c74 into master Feb 27, 2026
10 of 12 checks passed
@thet thet deleted the thet/remove-moved branch February 27, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants