Conversation
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@mauritsvanrees not urgent at all, but if you find the time could you please again do a release of plone.base? This already merged PR needs to go into a release, so that this PR here can get green. |
The following utility functions were already moved to plone.base.utils and are removed from CMFPlone: - `transaction_note` - `check_id` - `_check_for_collision`
a61c7ce to
f503157
Compare
@thet Done. |
Remove utility functions which were already moved to plone.base.
The following utility functions were already moved to plone.base.utils and are
removed from CMFPlone:
Requires: plone/plone.base#109
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #