Add option to fix forced subtitles handling in PMS#293
Open
pannal wants to merge 1 commit intoplexinc:developfrom
Open
Add option to fix forced subtitles handling in PMS#293pannal wants to merge 1 commit intoplexinc:developfrom
pannal wants to merge 1 commit intoplexinc:developfrom
Conversation
…ndling from the PMS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHI (If applicable): #
Description:
The PMS has a long standing issue, that it pre-selects forced subtitles over full subtitles. I've reported that ages ago and it hasn't been fixed since. The PMS should have an option to disable this behaviour.
It's arguably wrong for a client to fix this; but as an option that's off by default, this is IMHO OK.
When there is a media file with both forced and normal subtitles for the same language and the user hasn't explicitly selected the forced one, select the non-forced one by default (external have precedence over embedded, to keep the same behaviour as the PMS).
Checklist: