Skip to content

feat(options): add timeout options #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
behnammodi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(options): add timeout options #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9b765
feat(options): add timeout options
behnammodi Apr 4, 2021
e99e92b
fix(didTimeout): bug in calc
behnammodi Apr 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
window.requestIdleCallback =
window.requestIdleCallback ||
function(cb) {
function(cb, options) {
var options = options || {};
var timeout = options.timeout || 1;
Copy link

@samal-rasmussen samal-rasmussen Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually used as the timeout.

Copy link
Author

@behnammodi behnammodi Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand

Copy link
Author

@behnammodi behnammodi Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think we have to implement all options in polyfill

Copy link

@samal-rasmussen samal-rasmussen Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the point of the timeout to change the timeout argument given to setTimeout?

Copy link
Author

@behnammodi behnammodi Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code always say to callback didTimeout is false, but that is not correct

Copy link
Author

@behnammodi behnammodi Jun 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do you any questions? or you are not sure about this PR

var start = Date.now();
return setTimeout(function() {
cb({
didTimeout: false,
get didTimeout() {
return options.timeout ? false : (Date.now() - start) > timeout;
},
timeRemaining: function() {
return Math.max(0, 50 - (Date.now() - start));
},
Expand Down