feat(options): add timeout options #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behnammodi
force-pushed
the
options-timeout
branch
from
67c3dd8 to
e99e92b
Compare
| function(cb) { | ||
| function(cb, options) { | ||
| var options = options || {}; | ||
| var timeout = options.timeout || 1; |
There was a problem hiding this comment.
This isn't actually used as the timeout.
Author
There was a problem hiding this comment.
But I think we have to implement all options in polyfill
There was a problem hiding this comment.
Isn't the point of the timeout to change the timeout argument given to setTimeout?
Author
There was a problem hiding this comment.
The previous code always say to callback didTimeout is false, but that is not correct
Author
There was a problem hiding this comment.
So do you any questions? or you are not sure about this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pladaria Could you please review this PR, and if everything was ok, publish it on npm?