Skip to content

Update CI to include test on macos runner #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjones merged 2 commits into from
May 30, 2025
Merged

Update CI to include test on macos runner #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3afc94f
Update CI to include test on macos and windowns runner
nitinprakash96 May 28, 2025
d937c84
limit allowed characters in domain name
nitinprakash96 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ jobs:
os: [ubuntu-latest]
cabal: ["3.12.1.0"]
ghc: ["9.6.7", "9.8.4", "9.10.2"]
include:
# Test only with latest GHC on macOS
- os: macOS-latest # arm based macos system
ghc: 9.10.2
steps:
- name: Clone Repository
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions test/TestData.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module TestData
)
where

import Addy.Internal.Char (utf8NonAscii)
import Addy.Internal.Char (utf8NonAscii, atext)
import Data.Aeson (FromJSON)
import qualified Data.Aeson as Aeson
import Data.Char
Expand Down Expand Up @@ -200,7 +200,7 @@ genDomain =
where
okay :: Text -> Bool
okay t =
Text.all allowedChar t
Text.all atext t
Copy link
Contributor Author

@nitinprakash96 nitinprakash96 May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some flakiness in the tests. A couple of them result in InvalidCharactersError and InvalidLengthError. This change fixes the first one. Domain name is considered valid over atext. But property tests were allowing all ascii characters (Eg: ;).

&& not (Text.isPrefixOf "-" t)
&& not (Text.isSuffixOf "-" t)

Expand Down