Update CI to include test on macos runner #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you so much! |
nitinprakash96
commented
May 30, 2025
| okay :: Text -> Bool | ||
| okay t = | ||
| Text.all allowedChar t | ||
| Text.all atext t |
Contributor
Author
There was a problem hiding this comment.
There is some flakiness in the tests. A couple of them result in InvalidCharactersError and InvalidLengthError. This change fixes the first one. Domain name is considered valid over atext. But property tests were allowing all ascii characters (Eg: ;).
nitinprakash96
changed the title
Owner
|
Fantastic! Thank you so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
I think it should be enough to test with latest GHC on MacOS runner.
Edit: Gave up on Windows CI for now as it has it's own issue which I'm not able to pinpoint.