Skip to content

test: align Claude adapter thread identity assertions #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dl-alexandre wants to merge 1 commit into from
+12 −8
Closed

test: align Claude adapter thread identity assertions #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions apps/server/src/provider/Layers/ClaudeCodeAdapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,14 +546,14 @@ describe("ClaudeCodeAdapterLive", () => {
provider: "claudeCode",
runtimeMode: "full-access",
});
assert.equal(session.threadId, undefined);
assert.equal(String(session.threadId), String(THREAD_ID));

const turn = yield* adapter.sendTurn({
threadId: session.threadId,
input: "hello",
attachments: [],
});
assert.equal(turn.threadId, undefined);
assert.equal(String(turn.threadId), String(THREAD_ID));

harness.query.emit({
type: "stream_event",
Expand Down Expand Up @@ -592,13 +592,14 @@ describe("ClaudeCodeAdapterLive", () => {
const sessionStarted = runtimeEvents[0];
assert.equal(sessionStarted?.type, "session.started");
if (sessionStarted?.type === "session.started") {
assert.equal("threadId" in sessionStarted, false);
assert.equal(String(sessionStarted.threadId), String(THREAD_ID));
}

const threadStarted = runtimeEvents[4];
assert.equal(threadStarted?.type, "thread.started");
if (threadStarted?.type === "thread.started") {
assert.equal(threadStarted.threadId, "sdk-thread-real");
assert.equal(String(threadStarted.threadId), String(THREAD_ID));
assert.equal(threadStarted.payload.providerThreadId, "sdk-thread-real");
}
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Expand Down Expand Up @@ -700,9 +701,9 @@ describe("ClaudeCodeAdapterLive", () => {
runtimeMode: "full-access",
});

assert.equal(session.threadId, "resume-thread-1");
assert.equal(String(session.threadId), String(RESUME_THREAD_ID));
assert.deepEqual(session.resumeCursor, {
threadId: "resume-thread-1",
threadId: String(RESUME_THREAD_ID),
resume: "550e8400-e29b-41d4-a716-446655440000",
resumeSessionAt: "assistant-99",
turnCount: 3,
Expand Down Expand Up @@ -849,7 +850,7 @@ describe("ClaudeCodeAdapterLive", () => {
event?: {
provider?: string;
method?: string;
threadId?: string;
providerThreadId?: string;
turnId?: string;
};
}> = [];
Expand Down Expand Up @@ -911,7 +912,10 @@ describe("ClaudeCodeAdapterLive", () => {

assert.equal(nativeEvents.length > 0, true);
assert.equal(nativeEvents.some((record) => record.event?.provider === "claudeCode"), true);
assert.equal(nativeEvents.some((record) => String(record.event?.threadId) === String(session.threadId)), true);
assert.equal(
nativeEvents.some((record) => record.event?.providerThreadId === "sdk-session-native-log"),
true,
);
assert.equal(
nativeEvents.some((record) => String(record.event?.turnId) === String(turn.turnId)),
true,
Expand Down