test: align Claude adapter thread identity assertions#243
test: align Claude adapter thread identity assertions#243dl-alexandre wants to merge 1 commit intopingdotgg:codething/648ca884-claudefrom
Conversation
|
@dl-alexandre is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes the failing CI assertions in ClaudeCodeAdapter.test.ts for PR #179.
Updates stale expectations to match current adapter behavior:
Validated locally:
Note
Align Claude adapter tests to assert external thread IDs and provider-native identifiers in ClaudeCodeAdapter.test.ts
Updates tests to assert
session.threadIdandturn.threadIdas external IDs viaString(...), expectthread.startedto includepayload.providerThreadId, and switch native observability checks fromevent.event.threadIdtoevent.event.providerThreadIdin ClaudeCodeAdapter.test.ts.📍Where to Start
Start with the test cases in ClaudeCodeAdapter.test.ts, focusing on expectations for
session.threadId,turn.threadId,thread.startedpayloads, and observability event assertions.Macroscope summarized 47ddb15.