Use https://github.com/docker/github-builder to build and push image#152
Use https://github.com/docker/github-builder to build and push image#152
Conversation
555de50 to
dda2f9d
Compare
|
Thanks for looking at this - it was on my todo list to get around to! |
|
If you feel like porting some ideas from #135 feel free to push to this branch. |
68b1a2c to
50ef829
Compare
Signed-off-by: yubiuser <github@yubiuser.dev>
50ef829 to
9214ec1
Compare
|
Look how nicely it re-used the cache (RISCV finished in 47 secs) 🥰 |
Signed-off-by: yubiuser <github@yubiuser.dev>
|
Are there any disadvantages/downsides to not signing the images? |
|
We don't get
We reduce down stream supply chain security a bit if we don't sign. P.s. so far we also did not sign the image. |
…formation Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
What does this PR aim to accomplish?:
Use https://github.com/docker/github-builder to build and push image.
It's the same we use now in https://github.com/pi-hole/docker-pi-hole/blob/development/.github/workflows/build-and-publish.yml.
It reduced complexity a lot and offloads maintenance to the resueable workflow maintainers.
Supersedes #149
By submitting this pull request, I confirm the following:
git rebase)