Skip to content

Refactor and cleanup FTL build workflows#135

Closed
PromoFaux wants to merge 4 commits intomasterfrom
rework-gha-yaml
Closed

Refactor and cleanup FTL build workflows#135
PromoFaux wants to merge 4 commits intomasterfrom
rework-gha-yaml

Conversation

@PromoFaux
Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

I had initially wanted just to add in an additional condition for tagging nightly, however while I was there I took some inspiration from the build process of the docker-pi-hole image

  • tag nightly builds on both schedule and push to master branch
  • tag latest and exact tag name on "release" types
  • only set up QEMU for relevant platform
  • No need for QEMU on the merge job
  • Set riscv64 runner to arm variant
  • utilise YAML anchors to reduce duplication
  • separate publish and test jobs to make it easier to follow and to simplify the logic of when it should run

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team as a code owner December 15, 2025 00:52
Comment thread .github/workflows/ftl-build-publish.yml Fixed
Comment thread .github/workflows/ftl-build-publish.yml Fixed
Comment thread .github/workflows/ftl-build-test.yml Fixed
@dschaper
Copy link
Copy Markdown
Member

Looks like the security scan bot has left some comments and suggestions for limiting access.

@PromoFaux
Copy link
Copy Markdown
Member Author

They've been addressed :)

Comment thread .github/workflows/ftl-build-test.yml Outdated
 - tag nightly builds on both schedule and push to master branch
 - tag latest on release types
 - only set up QEMU for relevant platform
 - No need for QEMU on the merge job
 - Set riscv64 runner to arm variant
 - utilise YAML anchors to reduce duplication
 - separate publish and test jobs to make it easier to follow

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
…ent. Implement retry logic from the FTL repo

remove redundant environment variable definitions.
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux force-pushed the rework-gha-yaml branch 2 times, most recently from 2c4f799 to dfdeb2f Compare January 2, 2026 13:01
…a-file and read it in the next step

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@yubiuser
Copy link
Copy Markdown
Member

@PromoFaux There are merge conflicts

@yubiuser
Copy link
Copy Markdown
Member

I've been thinking about using https://github.com/docker/github-builder for those workflows as well, but the retry action (https://github.com/nick-fields/retry) likely won't work with the reusable workflow approach.
If we switch, we gain much easier workflows, but at the expense of needing to manually re-start failed runs.

@PromoFaux
Copy link
Copy Markdown
Member Author

Closing in favour of #152 - will push a change to that

@PromoFaux PromoFaux closed this Mar 31, 2026
PromoFaux added a commit that referenced this pull request Mar 31, 2026
…formation

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux deleted the rework-gha-yaml branch April 5, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants