Skip to content

docs: update planning doc with implementation status and infrastructure decisions#66

Merged
JustAGhosT merged 1 commit intodevfrom
feat/correlation-id-propagation
Mar 15, 2026
Merged

docs: update planning doc with implementation status and infrastructure decisions#66
JustAGhosT merged 1 commit intodevfrom
feat/correlation-id-propagation

Conversation

@JustAGhosT
Copy link
Copy Markdown
Contributor

@JustAGhosT JustAGhosT commented Mar 15, 2026

Summary

Update the implementation plan with current status and infrastructure decisions.

Changes

  • Document Phase 1 (OTEL) and Phase 2 (correlation ID) implementation
  • Add Method A for passing correlation IDs via request metadata
  • Add infrastructure decisions:
    • No Redis needed initially
    • Shared-per-env acceptable
    • Direct ACA ingress (no Front Door)
    • Use naming (align with Mystira)
  • Add Terraform integration notes for shared-infra adoption

Files Changed

Summary by CodeRabbit

  • Documentation
    • Updated planning documentation with enhanced correlation ID propagation strategy, introducing metadata-based (recommended) and header-based (future enhancement) implementation methods along with concrete examples.
    • Added comprehensive infrastructure planning documentation covering shared infrastructure adoption, Terraform integration guidelines, resource configuration specifications, naming conventions, and environment setup details.

…re decisions

- Document Phase 1 (OTEL) and Phase 2 (correlation ID) implementation
- Add Method A for passing correlation IDs via request metadata
- Add infrastructure decisions: no Redis, shared-per-env, direct ACA ingress, staging naming
- Add Terraform integration notes for shared-infra adoption
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2941de6-d23b-417e-bcb2-0cc0c6efb301

📥 Commits

Reviewing files that changed from the base of the PR and between 534c5dd and 065e118.

📒 Files selected for processing (1)
  • docs/planning/request_to_token_attribution.md

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

Documentation file updated to detail correlation ID propagation strategies for request-to-token attribution. Phase 2 planning now includes two methods: metadata-based approach (recommended) and future HTTP header extraction. Infrastructure planning sections added covering shared infrastructure adoption with Redis, storage, and Terraform integration specifics.

Changes

Cohort / File(s) Summary
Request Attribution Planning
docs/planning/request_to_token_attribution.md
Phase 2 expanded with two correlation ID propagation methods: Method A (recommended, metadata-based with JSON example) and Method B (future header extraction). Infrastructure planning details added including shared infrastructure decisions table (Redis, storage, isolation, naming) and Terraform integration notes (module location, shared resources, naming conventions, secrets handling). Implementation options section updated to reflect OpenTelemetry Phase 1 selection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hops through the plans with glee,
Correlation IDs now flow free!
Metadata paths and headers bright,
Infrastructure shines in spotlight,
Terraform notes made everything right!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/correlation-id-propagation
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JustAGhosT JustAGhosT merged commit 3872830 into dev Mar 15, 2026
3 of 5 checks passed
@JustAGhosT JustAGhosT deleted the feat/correlation-id-propagation branch March 15, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant