Skip to content

Conversation

@shajoezhu
Copy link
Collaborator

@shajoezhu shajoezhu commented Dec 14, 2025

Pull Request

DESCRIPTION GOES HERE
image

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

  • Title: Place Closes #127 at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.

@shajoezhu shajoezhu changed the title adding google translation Closes #127 adding google translation Dec 14, 2025
@bms63
Copy link
Collaborator

bms63 commented Dec 14, 2025

@ShuaiZ2020 FYI

_quarto.yml Outdated
text: |
<script type="text/javascript">
function googleTranslateElementInit() {
new google.translate.TranslateElement({pageLanguage: 'en', includedLanguages: 'zh-CN'}, 'google_translate_element');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @bms63 , I think we just need to add other languages here as a list

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about a poll in the slack channel? @rossfarrugia nice to get a few more language options.

@orladoylenvs mabye nice for the blog post as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature! I was worried adding more languages might slow it down but AI tells me:

More languages in the dropdown $\approx$ no significant speed difference

I would suggest we add options for French, Spanish, Japanese and Hindi here. I imagine that way we are inclusive for a large proportion of pharmaverse users.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @rossfarrugia , updated :)

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!!

@rossfarrugia rossfarrugia merged commit a098a45 into main Dec 15, 2025
5 checks passed
@rossfarrugia rossfarrugia deleted the chinese branch December 15, 2025 16:24
@rossfarrugia
Copy link
Contributor

Looks amazing - thanks Joe!! ❤️

@shajoezhu
Copy link
Collaborator Author

Thanks Ross! Thanks Ben!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants