-
Notifications
You must be signed in to change notification settings - Fork 17
Closes #127 adding google translation #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ShuaiZ2020 FYI |
_quarto.yml
Outdated
| text: | | ||
| <script type="text/javascript"> | ||
| function googleTranslateElementInit() { | ||
| new google.translate.TranslateElement({pageLanguage: 'en', includedLanguages: 'zh-CN'}, 'google_translate_element'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @bms63 , I think we just need to add other languages here as a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about a poll in the slack channel? @rossfarrugia nice to get a few more language options.
@orladoylenvs mabye nice for the blog post as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature! I was worried adding more languages might slow it down but AI tells me:
More languages in the dropdown
I would suggest we add options for French, Spanish, Japanese and Hindi here. I imagine that way we are inclusive for a large proportion of pharmaverse users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @rossfarrugia , updated :)
bms63
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!!
|
Looks amazing - thanks Joe!! ❤️ |
|
Thanks Ross! Thanks Ben! |
Pull Request
DESCRIPTION GOES HERE

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!
Closes #127at the beginning of your PR title. Use the Edit button in the top-right if you need to update.DESCRIPTIONfile.DESCRIPTIONfile'sImportssection.