-
Notifications
You must be signed in to change notification settings - Fork 16
#335 pharmaverse examples #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bms63
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - just a couple minor suggestions. Shall we get this out earlier than 2026?
|
@aaehmann FYI |
|
@orladoylenvs be sure to put closes in PR Title so GH auto-closes the issue. Sometimes linking on the side doesn't always auto close it for some reason |
rossfarrugia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Orla thanks! Only some minor comments
|
@orladoylenvs lets also include something on the latest cool feature of language translations: pharmaverse/examples#126 - i just merged this so should be live on the site soon |
|
Thanks for the review! I need to do the linting, spelling, etc but hopefully the content is in good shape and I think addressed all your comments but do feel free to make additional suggestions! |
|
@orladoylenvs I fixed the spelling and styling issues coming from other files. @aaehmann is going to try and get someone from the new blog team to address the failing links. Those are from much older blog posts. So no worries on the actions now. :) |
…her than the examples currently being available in other programming languages like python
rossfarrugia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Orla! i made one minor change to one sentence just to make clear we meant spoken languages rather than programming languages, so people don't get confused that we don't currently offer these examples in python etc.
|
If this gets merged in it won't get published until the January date and that depends on someone publishing something on or after that date. Do we want to change the date to today and merge in so it is published or wait to merge this in on January 12th? |
|
Fine for me for this to be published anytime from now and not wait til after Jan 12th |
|
Sounds good - should I merge already? and second question how do I change the publishing date? |
Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com>
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge intomain.CICD.Rline by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Python", "Community", "Conferences", "Submissions", "Technical", "DEI")for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltagsfor consistency.descriptionfield at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)