Conversation
|
I actually tried to pass over maintenance to someone else twice, but it didn't really work out. I thought about putting this repo in maintenance mode, but I figured I would only do so, if someone complains. Anyways, this doesn't belong here. I would prefer if you included a full implementation of strtobool, not just y/n, because I don't want to break anyone's workflows or scripts for no good reason. see here: https://docs.python.org/2/distutils/apiref.html#distutils.util.strtobool And I am very skeptical of those versioning changes. I can't believe parsing a Python file with regexes is the canonical new way to handle this. I'll have to research later today. |
No problems, I will do that! |
Same here, but other methods I found were looking even worse, so I decided to go with that. My knowledge of Python is kinda limited though, so I’m open to ideas. |
|
I think I revamp the package as a whole and start using pyproject.toml. While setuptools will be supported indefinitely, that seems to be the future-proof way. I only had 45min to work on this today, but I might get a couple hours tomorrow. So please just replace strtobool, if you want and I'll try to attend to the rest. |
|
Confirmed! I probably will have some time today to fix it. |
…description of distutils.util.strtobool
…code to fix main script" This reverts commit 01de09d.
|
Done! |
This PR fixes compatibility issues for Python v3.12. Namely, it removes deprecated import for distutils and replaces related code with the closest alternative. I'm not the right person to fix that, so if you have comments or suggestions, I'm totally open for fixes.
The default installation from PyPi wasn't working for me, and I went to GH to figure out the issue. Ended up fixing it :)
I don't know how widespread the problem is across platforms, but I had it in my nobrainer install on Win11.
The repository looks a bit lonely and abandoned to me, so to anyone having the same problem as me:
makelove.pip install <path/to/you/fixed/local/repository>.