Avoid future deprecation of setuptools by migrating to pyproject.toml#51
Open
paulgeringer wants to merge 1 commit intopfirsich:masterfrom
Open
Avoid future deprecation of setuptools by migrating to pyproject.toml#51paulgeringer wants to merge 1 commit intopfirsich:masterfrom
paulgeringer wants to merge 1 commit intopfirsich:masterfrom
Conversation
Owner
|
For #48 I already started a pyproject.toml. This is what I had: [build-system]
requires = ["setuptools>=64"]
build-backend = "setuptools.build_meta"
[tool.setuptools.packages.find]
include = ["makelove"]
[project]
name = "makelove"
version = "0.0.14"
dependencies = [
"Pillow>=7.0",
"appdirs>=1.4.3",
"toml>=0.10"
]
requires-python = ">=3.7"
authors = [
{name = "Joel Schumacher", email = "joelschum@gmail.com"},
{name = "Josh Perry", email = "joshperry@outlook.com"},
]
maintainers = [
{name = "Joel Schumacher", email = "joelschum@gmail.com"},
{name = "Josh Perry", email = "joshperry@outlook.com"},
]
description = "A packaging tool for [löve](https://love2d.org) games"
readme = "README.md"
license = "MIT"
license-files = ["LICENSE"]
classifiers = [
"Programming Language :: Python :: 3",
"Operating System :: OS Independent",
"Topic :: Software Development :: Build Tools",
"Topic :: Games/Entertainment :: Build Tools",
]
[project.urls]
Repository = "https://github.com/pfirsich/makelove"
[project.scripts]
makelove = "makelove:main"I think I ran into a problem when verifying that you could still install makelove on all relevant platforms with their default Python versions (Windows, Ubuntu, Fedora, Pop-OS - which is what I use) and there was some issue. It turned out to be a multi-evening thing (even though I started thinking it would just be a few hours), so I dropped it. If you can list out the Python versions being used (ideally with links so I can verify) and make sure it still cleanly installs on all relevant platforms, I could merge some combined version of our pyproject.tomls. Also please remove the empty files or at least put them in a different commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow the project to continue working past the deprecation of
python setup.py.Build process would be:
instead of
python setup.pywith this change.Not 100% sure this is really necessary, but at least it gets the framework in place if this seems valuable.