Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/docs-379-ps-xxx-properties.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-expert": patch
---

Internalize PS-XXX properties as framework-specific
21 changes: 12 additions & 9 deletions apps/create-expert/src/lib/agents-md-template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,21 +61,24 @@ create-expert (Coordinator)
- Expected inputs and outputs
- Domain-specific behaviors

**Perstack Properties** (always verified):
**Framework Quality Properties** (create-expert internal, always verified):

These ensure experts follow Perstack best practices.
See docs/making-experts/best-practices.md for public guidelines.

*Security:*
- PS-SEC-01: Minimal tool access - uses \`pick\` for only needed tools
- PS-SEC-02: Minimal environment - uses \`requiredEnv\` for only needed variables
- PS-SEC-03: Maintains boundaries - protects internal information
- Minimal tool access: Uses \`pick\` for only needed tools
- Minimal environment: Uses \`requiredEnv\` for only needed variables
- Maintains boundaries: Protects internal information

*Design:*
- PS-DESIGN-01: Single responsibility - does one thing well
- PS-INST-01: Declarative instructions - policies not procedures
- PS-INST-02: Contains domain knowledge
- Single responsibility: Does one thing well
- Declarative instructions: Policies not procedures
- Contains domain knowledge: Expertise embedded in instruction

*Output:*
- PS-OUT-01: Uses \`attemptCompletion\` for final output
- PS-OUT-02: Error handling - graceful with helpful messages
- Uses \`attemptCompletion\`: Signals completion properly
- Error handling: Graceful with helpful messages

## CLI Reference

Expand Down
21 changes: 12 additions & 9 deletions apps/create-expert/src/lib/create-expert-toml.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,24 @@ Return a structured list of properties:
### User Properties (from requirements)
1. [Property name]: [Description] - [Success criteria]

### Perstack Properties (PS-XXX format)
### Framework Quality Properties (create-expert internal)

These properties ensure experts follow Perstack best practices.
See docs/making-experts/best-practices.md for the public guidelines.

**Security:**
- PS-SEC-01: Minimal tool access - uses \`pick\` for only needed tools
- PS-SEC-02: Minimal environment - uses \`requiredEnv\` for only needed variables
- PS-SEC-03: Maintains boundaries - protects internal information
- Minimal tool access: Uses \`pick\` for only needed tools
- Minimal environment: Uses \`requiredEnv\` for only needed variables
- Maintains boundaries: Protects internal information

**Design:**
- PS-DESIGN-01: Single responsibility - does one thing well
- PS-INST-01: Declarative instructions - policies not procedures
- PS-INST-02: Contains domain knowledge
- Single responsibility: Does one thing well
- Declarative instructions: Policies not procedures
- Contains domain knowledge: Expertise embedded in instruction

**Output:**
- PS-OUT-01: Uses \`attemptCompletion\` for final output
- PS-OUT-02: Error handling - graceful with helpful messages
- Uses \`attemptCompletion\`: Signals completion properly
- Error handling: Graceful with helpful messages

### Usability Properties (always verified)
1. Zero-Config: Demo mode works without any setup OR setup is fully automated
Expand Down