Skip to content

docs(create-expert): internalize PS-XXX properties as framework-specific#389

Merged
FL4TLiN3 merged 2 commits intomainfrom
docs/379-ps-xxx-properties
Jan 3, 2026
Merged

docs(create-expert): internalize PS-XXX properties as framework-specific#389
FL4TLiN3 merged 2 commits intomainfrom
docs/379-ps-xxx-properties

Conversation

@FL4TLiN3
Copy link
Contributor

@FL4TLiN3 FL4TLiN3 commented Jan 3, 2026

Summary

Renames "Perstack Properties (PS-XXX format)" to "Framework Quality Properties (create-expert internal)" to clarify these are internal to the create-expert framework, not official Perstack public concepts.

Changes

Before:

### Perstack Properties (PS-XXX format)

*Security:*
- PS-SEC-01: Minimal tool access - uses `pick` for only needed tools
- PS-SEC-02: Minimal environment - uses `requiredEnv` for only needed variables

After:

### Framework Quality Properties (create-expert internal)

These properties ensure experts follow Perstack best practices.
See docs/making-experts/best-practices.md for the public guidelines.

*Security:*
- Minimal tool access: Uses `pick` for only needed tools
- Minimal environment: Uses `requiredEnv` for only needed variables

Files Changed

  • apps/create-expert/src/lib/create-expert-toml.ts
  • apps/create-expert/src/lib/agents-md-template.ts

This avoids confusion with the public "Five Principles" documented in docs/making-experts/best-practices.md.

Closes #379

Test plan

  • CI passes
  • No behavior changes expected

Note

Clarifies that quality checks are framework-internal, not public Perstack concepts.

  • Rename Perstack Properties (PS-XXX format)Framework Quality Properties (create-expert internal) in agents-md-template.ts and create-expert-toml.ts
  • Remove PS-XXX codes (e.g., PS-SEC-01) and restate bullets as plain quality criteria (security, design, output)
  • Add explanatory text pointing to docs/making-experts/best-practices.md
  • No runtime/logic changes; string/template documentation updates only
  • Add changeset for patch release

Written by Cursor Bugbot for commit 9176a40. This will update automatically on new commits. Configure here.

Rename "Perstack Properties (PS-XXX format)" to "Framework Quality Properties
(create-expert internal)" to clarify these are internal to the create-expert
framework, not official Perstack public concepts.

Changes:
- Remove PS-XXX identifiers (PS-SEC-01, PS-DESIGN-01, etc.)
- Rename to "Framework Quality Properties"
- Add note referencing docs/making-experts/best-practices.md for public guidelines
- Update both create-expert-toml.ts and agents-md-template.ts

This avoids confusion with the public "Five Principles" documented in
docs/making-experts/best-practices.md.

Closes #379

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@FL4TLiN3 FL4TLiN3 merged commit 9d5d153 into main Jan 3, 2026
7 checks passed
@FL4TLiN3 FL4TLiN3 deleted the docs/379-ps-xxx-properties branch January 3, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: document Perstack Properties (PS-XXX) framework or internalize as create-expert-only concept

1 participant