docs(create-expert): internalize PS-XXX properties as framework-specific#389
Merged
docs(create-expert): internalize PS-XXX properties as framework-specific#389
Conversation
Rename "Perstack Properties (PS-XXX format)" to "Framework Quality Properties (create-expert internal)" to clarify these are internal to the create-expert framework, not official Perstack public concepts. Changes: - Remove PS-XXX identifiers (PS-SEC-01, PS-DESIGN-01, etc.) - Rename to "Framework Quality Properties" - Add note referencing docs/making-experts/best-practices.md for public guidelines - Update both create-expert-toml.ts and agents-md-template.ts This avoids confusion with the public "Five Principles" documented in docs/making-experts/best-practices.md. Closes #379 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames "Perstack Properties (PS-XXX format)" to "Framework Quality Properties (create-expert internal)" to clarify these are internal to the create-expert framework, not official Perstack public concepts.
Changes
Before:
After:
Files Changed
apps/create-expert/src/lib/create-expert-toml.tsapps/create-expert/src/lib/agents-md-template.tsThis avoids confusion with the public "Five Principles" documented in
docs/making-experts/best-practices.md.Closes #379
Test plan
Note
Clarifies that quality checks are framework-internal, not public Perstack concepts.
Perstack Properties (PS-XXX format)→Framework Quality Properties (create-expert internal)inagents-md-template.tsandcreate-expert-toml.tsPS-SEC-01) and restate bullets as plain quality criteria (security, design, output)docs/making-experts/best-practices.mdWritten by Cursor Bugbot for commit 9176a40. This will update automatically on new commits. Configure here.