Skip to content

Refactored BaseExperiment class to enhance VR support and usability #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pellet merged 2 commits into from
Nov 30, 2025
Merged

Refactored BaseExperiment class to enhance VR support and usability #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a5b3e4
Fix early return bug in Experiment.py setup() method
claude Nov 30, 2025
67922b0
Correct fix: Handle show_instructions() return value properly
claude Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eegnb/experiments/Experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def setup(self, instructions=True):

# Show Instruction Screen if not skipped by the user
if instructions:
return self.show_instructions()
if not self.show_instructions():
return False

# Checking for EEG to setup the EEG stream
if self.eeg:
Expand Down
Loading