Refactored BaseExperiment class to enhance VR support and usability
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup() method was incorrectly returning early when instructions were shown (line 128), preventing the rest of the setup code from executing. This meant the EEG initialization and other setup steps were skipped when instructions=True. Changed line 128 from 'return self.show_instructions()' to 'self.show_instructions()' to allow setup to complete properly.
The previous fix was incomplete. show_instructions() returns False when the user cancels and True when they proceed. The setup() method should return False if the user cancels, but continue with the rest of the setup if they proceed. Changed to check the return value and only return early if False.
pellet
deleted the
claude/fix-experiment-return-bug-01QNHoTagHvdXzP3wiSDAWdY
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stereoscopicparameter) with positional eye rendering._run_trial_loopto simplifyrunand make it accessible to inheriting classes.present_iti) and post-trial clean-up.