Skip to content

fix: [WLEO-990] add missing trust_chain, iat and exp claims in wallet attestation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flaviodelgrosso merged 2 commits into from
Mar 3, 2026
Merged

fix: [WLEO-990] add missing trust_chain, iat and exp claims in wallet attestation #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a507d51
fix: add missing trust_chain, iat and exp claims in wallet attestation
flaviodelgrosso Feb 27, 2026
847c778
fix(test): v2 now performs two signing paths
flaviodelgrosso Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e-functions-api/src/adapters/azure/functions/__tests__/create-wallet-attestations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('CreateWalletAttestationFn', () => {
env.walletInstanceRepository.get.mockReturnValueOnce(
TE.right(O.some(await mkWalletInstance())),
);
env.jwksRepository.get.mockReturnValueOnce(TE.right(aJwkKeyPair));
env.jwksRepository.get.mockReturnValue(TE.right(aJwkKeyPair));

const actual = await CreateWalletAttestationFnV2(env)(request, ctx);

Expand Down
8 changes: 7 additions & 1 deletion apps/azure-functions-api/src/domain/openid-federation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { pipe } from 'fp-ts/lib/function';
// TODO: Move to configuration
export const baseURL = 'https://io-d-itn-eudiw-api-func-01.azurewebsites.net';

export const getFederationMetadata = pipe(
const getFederationMetadataPayload = pipe(
RTE.Do,
RTE.apSW('jwks', getJwkPublicKeyList),
RTE.map(({ jwks }) => ({
Expand Down Expand Up @@ -50,8 +50,14 @@ export const getFederationMetadata = pipe(
},
sub: baseURL,
})),
);

export const getFederationEntityStatement = pipe(
getFederationMetadataPayload,
RTE.flatMap((payload) =>
signJwt({ header: { typ: 'entity-statement+jwt' }, payload }),
),
RTE.map(({ jwt }) => jwt),
);

export const getFederationMetadata = getFederationEntityStatement;
10 changes: 7 additions & 3 deletions apps/azure-functions-api/src/domain/wallet-attestations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { validateNonce } from './nonce';
import { WalletInstance, getWalletInstance } from './wallet-instance';
import { User } from './user';
import { signJwt } from './signer';
import { baseURL } from './openid-federation';
import { baseURL, getFederationEntityStatement } from './openid-federation';

export const WalletAttestationRequestHeader = t.type({
alg: t.string,
Expand Down Expand Up @@ -123,18 +123,22 @@ const verifyHardwareSignature = (
// TODO: Take baseURL and other information from openid-federation metadata
const makeWalletAttestation = (war: WalletAttestationRequest) =>
pipe(
RTE.of({
RTE.bindTo('entityConfigurationJwt')(getFederationEntityStatement),
RTE.map(({ entityConfigurationJwt }) => ({
header: {
typ: 'oauth-client-attestation+jwt',
trust_chain: [entityConfigurationJwt],
},
payload: {
iss: baseURL,
aal: `${baseURL}/LoA/basic`,
sub: war.header.kid,
cnf: war.payload.cnf,
exp: war.payload.exp,
iat: war.payload.iat,
wallet_link: 'https://wp.example.org/',
wallet_name: 'wp.example.org',
},
}),
})),
RTE.flatMap(signJwt),
);
Loading