fix: [WLEO-990] add missing trust_chain, iat and exp claims in wallet attestation#44
Merged
flaviodelgrosso merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
|
Collaborator
Author
|
I've just added the entity configuration jwt in the trust chain but do we need to also have subordinate statements emitted from TA? @manuraf |
Contributor
|
I think we can ignore subordinate statement |
manuraf
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how federation metadata and entity statements are handled in the wallet attestation flow, improving modularity and ensuring that JWTs are properly linked to the federation entity statement. The changes also update the wallet attestation creation logic to include additional fields and the trust chain in the JWT header.
Federation Metadata & Entity Statement Refactoring:
getFederationMetadataPayload, and introducedgetFederationEntityStatementto generate a signed JWT entity statement.getFederationMetadatanow referencesgetFederationEntityStatementfor clarity and modularity. [1] [2]wallet-attestations.tsto use the newgetFederationEntityStatementfunction, ensuring consistent access to federation entity statements.Wallet Attestation JWT Improvements:
trust_chainarray of the JWT header, along with new fieldsexpandiatin the payload. This strengthens attestation validity and traceability.Test Consistency:
.mockReturnValueinstead of.mockReturnValueOnce, ensuring consistent test behavior.