Skip to content

Conversation

@Lucccyo
Copy link
Contributor

@Lucccyo Lucccyo commented Jan 16, 2026

Merlin displays a signature-help response on every part of a function call, including the function name.
However, signature-help should appear only on function parameters.
The signature-help command should not return an answer for function names.

Copy link
Contributor

@liam923 liam923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. Could you just fixup the formatting issues?

@Lucccyo
Copy link
Contributor Author

Lucccyo commented Feb 2, 2026

Thanks for your review, it is now formatted @liam923 !

Copy link
Contributor

@liam923 liam923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll merge once CI passes (poke me if I forget to do so)

@liam923 liam923 merged commit 78e7043 into oxcaml:main Feb 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants