Signature help should not loop over the parameters once it is finished #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikostia
reviewed
Feb 9, 2026
Lucccyo
force-pushed
the
sig_help_looping_parameter
branch
from
02103c0 to
ce827d4
Compare
Compiler Merge ChecklistThis PR seems to merge changes from Flambda. Please be sure to follow the below steps:
If this PR is not merging changes from Flambda, feel free to ignore this comment |
Lucccyo
force-pushed
the
sig_help_looping_parameter
branch
from
ce827d4 to
04c31f9
Compare
ikostia
reviewed
Feb 10, 2026
ikostia
approved these changes
Feb 10, 2026
Contributor
ikostia
left a comment
ikostia
left a comment
There was a problem hiding this comment.
But please do accept my suggestion
Lucccyo
force-pushed
the
sig_help_looping_parameter
branch
from
6b3214d to
6f31bc9
Compare
Contributor
Contributor
|
Yes I think that's right, thanks. I'm not sure why the bot commented on this pr - it must've gotten confused by the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR downstreams the work on ocaml/merlin#2023.
It should be merged after #206, as it is based on it.