Switch test fixture metadata compression to gzip#30
Merged
Conversation
We don't actually care about what compression is used here, and in fact would prefer uncompressed metadata if it was supported. We do, however, need to use a compression algorithm which is supported on the version of createrepo_c that's distributed on our target Ubuntu platforms. Also clean up a GNUPG backup file that doesn't need to be committed. Signed-off-by: Scott K Logan <logans@cottsay.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 42.67% 42.67%
=======================================
Files 20 20
Lines 2615 2615
Branches 532 532
=======================================
Hits 1116 1116
Misses 1244 1244
Partials 255 255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tfoote
approved these changes
Jan 16, 2026
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
I didn't check the file hashes but assuming they're correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't actually care about what compression is used here, and in fact would prefer uncompressed metadata if it was supported. We do, however, need to use a compression algorithm which is supported on the version of createrepo_c that's distributed on our target Ubuntu platforms.
The command I used to generate the metadata is:
createrepo_c --no-database --general-compress-type gz .Also clean up a GNUPG backup file that doesn't need to be committed.
For clarity, this change only affects the package tests and won't result in any changes to the binaries we ship.