Skip to content

Add 'sync' command to Python client#29

Merged
cottsay merged 2 commits intomainfrom
cottsay/python-sync
Feb 10, 2026
Merged

Add 'sync' command to Python client#29
cottsay merged 2 commits intomainfrom
cottsay/python-sync

Conversation

@cottsay
Copy link
Member

@cottsay cottsay commented Jan 8, 2026

The Python method encompasses both the SYNC and SYNC_PATTERN Assuan commands, choosing the correct one depending on whether a pattern was given.

This includes some mild refactoring:

  • in client.c to de-duplicate the arch_list parsing.
  • in test_smoke.py to better support the new functionality.

@cottsay cottsay self-assigned this Jan 8, 2026
@cottsay cottsay added the enhancement New feature or request label Jan 8, 2026
@cottsay cottsay force-pushed the cottsay/python-sync branch from c6ae623 to a5ade95 Compare January 8, 2026 19:56
@cottsay
Copy link
Member Author

cottsay commented Jan 8, 2026

Looks like the test fixture repositories checked into this repo use zstd compression, which isn't supported by the version of createrepo-c in Ubuntu. I'll need to re-generate them with a compatible compression algorithm and re-sign the metadata.

Back to draft until that has been resolved.

@cottsay cottsay marked this pull request as draft January 8, 2026 20:08
@cottsay cottsay changed the base branch from main to cottsay/fixture-repo-compression January 9, 2026 16:36
@cottsay cottsay closed this Jan 9, 2026
@cottsay cottsay reopened this Jan 9, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.86%. Comparing base (44c151f) to head (e90668a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/python/client.c 83.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   42.67%   48.86%   +6.18%     
==========================================
  Files          20       20              
  Lines        2615     2642      +27     
  Branches      532      538       +6     
==========================================
+ Hits         1116     1291     +175     
+ Misses       1244     1046     -198     
- Partials      255      305      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay
Copy link
Member Author

cottsay commented Jan 9, 2026

Alright, this can be reviewed now, but I'm keeping it in draft until #30 has been merged.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the cottsay/python-sync branch from a5ade95 to 040deda Compare January 9, 2026 18:48
Base automatically changed from cottsay/fixture-repo-compression to main January 16, 2026 21:52
@cottsay cottsay marked this pull request as ready for review January 16, 2026 21:54
@cottsay cottsay merged commit c6f7f54 into main Feb 10, 2026
3 checks passed
@cottsay cottsay deleted the cottsay/python-sync branch February 10, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants