Always invalidate matching packages during sync#31
Merged
Conversation
Member
Author
|
Ha, well #29 also has a prerequisite change, so CI on this PR will fail until one or both of those upstream changes are merged. |
tfoote
approved these changes
Jan 16, 2026
Right now, invalidation only occurs in the target repository when there was at least one package matching sync criteria in the upstream repository. This behavior is unexpected given that the names of the matching packages have no bearing on what packages are invalidated during a typical sync operation. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
cottsay/sync-always-remove
branch
from
48d6b2b to
806da04
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 48.86% 48.97% +0.11%
==========================================
Files 20 20
Lines 2642 2638 -4
Branches 538 538
==========================================
+ Hits 1291 1292 +1
+ Misses 1046 1039 -7
- Partials 305 307 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, invalidation only occurs in the target repository when there was at least one package matching sync criteria in the upstream repository. This behavior is unexpected given that the names of the matching packages have no bearing on what packages are invalidated during a typical sync operation.
Closes #5
Requires #29, so submitted as draft until that is merged.