Skip to content

Add logic for known issues lookup #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelgonrod merged 5 commits into from
Mar 12, 2026
Merged

Add logic for known issues lookup #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66295bb
Created a script to return disabled issues
Mar 10, 2026
e69fd71
Added Logic to known_issues
Mar 10, 2026
e354449
Added an end to condition
Mar 10, 2026
8ab50e2
Changed condition to closed
Mar 11, 2026
6bca451
Added script to retreive all closed issues
Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions database/scripts/get_closed_known_issues.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
SELECT error_name,
github_issue
FROM test_fail_issues
WHERE status IN (
"COMPLETED",
"OBLIVIATED",
"DISABLED"
)
GROUP BY github_issue;
9 changes: 7 additions & 2 deletions database/scripts/lib/buildfarm_tools.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ def self.build_regressions_today(filter_known: false)

def self.known_issues(status: '%%') # Default is all issues. This is not the best approach, but better than none
# Keys: error_name, job_name, github_issue, status
run_command("./sql_run.sh get_known_issues.sql", args: [status.upcase])
if status == 'open'
run_command("./sql_run.sh get_opened_known_issues.sql")
elsif status == 'closed'
run_command("./sql_run.sh get_closed_known_issues.sql")
else
run_command("./sql_run.sh get_known_issues.sql", args: [status.upcase])
end
end

def self.error_appearances_in_job(test_name, job_name)
Expand All @@ -41,7 +47,6 @@ def self.test_regressions_all(filter_known: false, include_reports: true)
if filter_known
known_errors = known_issues(status: 'open')
known_errors.concat known_issues(status: 'disabled')
known_errors.concat known_issues(status: 'wontfix')
known_error_names = Set.new(known_errors.map { |e| [e['error_name'], e['job_name']] })
out.filter! { |e| !known_error_names.include? [e['error_name'], e['job_name']] }
end
Expand Down
Loading