Merged
Conversation
added 2 commits
March 10, 2026 10:39
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
Crola1702
requested changes
Mar 11, 2026
Crola1702
reviewed
Mar 11, 2026
added 2 commits
March 11, 2026 14:25
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes
known_issuesexplicitly support the disabled status and use specific script to retreive all types ofopened issues, now disabled known issues can be queried through the same helper interface used for open issues. This improves consistency in how known issues are retrieved and ensures disabled entries can be included in filtering and reporting flows.Changes
known_issuesto handle the disabled status explicitly.Considerations
This change is mainly meaningful at the helper/API level in
buildfarm_tools.rb, since it defines how other flows access disabled known issues. Its behavior still depends on the underlying SQL query returning the intended set of disabled records, so both layers should remain aligned.This script is part of https://github.com/osrf/buildfarm-tools-private/pull/69