Skip to content

Add logic for known issues lookup#229

Merged
miguelgonrod merged 5 commits intomainfrom
miguelgonrod/known_issues
Mar 12, 2026
Merged

Add logic for known issues lookup#229
miguelgonrod merged 5 commits intomainfrom
miguelgonrod/known_issues

Conversation

@miguelgonrod
Copy link
Contributor

@miguelgonrod miguelgonrod commented Mar 10, 2026

This change makes known_issues explicitly support the disabled status and use specific script to retreive all types of opened issues, now disabled known issues can be queried through the same helper interface used for open issues. This improves consistency in how known issues are retrieved and ensures disabled entries can be included in filtering and reporting flows.

Changes

  • Updated known_issues to handle the disabled status explicitly.
  • Routed disabled issue lookups through the dedicated SQL query for disabled known issues.
  • Improved downstream known-issue filtering/reporting behavior by allowing disabled issues to be retrieved through the shared helper path.

Considerations

This change is mainly meaningful at the helper/API level in buildfarm_tools.rb, since it defines how other flows access disabled known issues. Its behavior still depends on the underlying SQL query returning the intended set of disabled records, so both layers should remain aligned.

This script is part of https://github.com/osrf/buildfarm-tools-private/pull/69

miguelgonrod added 2 commits March 10, 2026 10:39
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
@miguelgonrod miguelgonrod requested a review from Crola1702 March 10, 2026 15:48
@miguelgonrod miguelgonrod self-assigned this Mar 10, 2026
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
miguelgonrod added 2 commits March 11, 2026 14:25
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
@miguelgonrod miguelgonrod requested a review from Crola1702 March 11, 2026 19:26
Copy link
Contributor

@Crola1702 Crola1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgonrod miguelgonrod merged commit 8e77cbb into main Mar 12, 2026
1 check failed
@miguelgonrod miguelgonrod deleted the miguelgonrod/known_issues branch March 12, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants