Open
Conversation
This should make it easier for contributors to test their changes
Currently, only a single rule to build a self-hosted docker container is defined.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
This change adds a
Dockerfile(and also aMakefile, and documents their usage inREADME.md).This is my 4th PR to this project, and yet I don't want to install Flask on my machine. Maybe there are more people like myself out there who are just as picky. This will help them to contribute to this project. Their workflow could be something like:
make [byol-docker]localhost:5000(by default).Hope this helps.
Thank you for the awesome book!