Merged
Conversation
Owner
|
Thanks, sorry I somehow missed your PRs! |
Contributor
Author
|
@orangeduck - It's all right. The honour is all mine. If you haven't yet seen it, perhaps you might be interested in this PR which should make it easier for people to self-host/test a local checkout of their changes. It might need some cleaning up, however. But I think it'll make it easier for people to test their typo-fix PRs, etc. without having to install all the deps. Also, I hope you would write some more books in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there!
Just fixing 2 typos that I spotted today.
I will keep an eye out for more of those during my re-reads. I think I'll be coming back to this book some more.