Conversation
There was a problem hiding this comment.
Thanks for the PR @vbrancat. Here are my couple of comments below
- Seongsu
|
@seongsujeong and @LiangJYu it would be great if you have time to go through this PR |
LiangJYu
left a comment
LiangJYu
left a comment
There was a problem hiding this comment.
In line with using a different init value for correction dict data, what do you think about:
- adding a bool dataset in the HDF5 indicating LUT(s) that were enabled?
- not writing disabled LUT(s) to HDF5?
src/compass/s1_geocode_slc.py
Outdated
| # if cfg.lut_params.enabled: | ||
| # # apply tropo corrections if weather file provided | ||
| # apply_tropo_corrections = cfg.weather_model_file is not None | ||
| # cslc_qa.compute_correction_stats( | ||
| # geo_burst_h5, apply_tropo_corrections, | ||
| # cfg.tropo_params.delay_type) |
There was a problem hiding this comment.
Will these commented lines be restored? Or temporary debug?
|
The |
|
The paths from my changes are a mess. I'll fix them as soon as #148 gets merged into main as I see no point in fixing them now and after another merge with main. |
path updates fix dataset access to correction flags update documentation remove unused code
|
Unable replicate failed unit test locally with a new environment created from Currently investigating why local docker fails differently than CircleCI. |
4 participants
This PR introduces the capability of computing individual correction LUTs by exposing Boolean flag in the schema for each individual correction.
TO DO: