Add individual correction metadata to CSLC-S1#156
Conversation
|
@seongsujeong this PR is ready to be reviewed |
seongsujeong
left a comment
seongsujeong
left a comment
There was a problem hiding this comment.
LGTM overall. Here I left couple of questions that you might want to check.
Approving this PR in advance expedite the process because my comments are minor
-- Seongsu
| Meta('los_solid_earth_tides_applied', bool(cfg.lut_params.enabled), | ||
| "If True, solid Earth tides correction has been applied in slant range direction"), |
There was a problem hiding this comment.
Just wondering if we will need to put a placeholder for sth. like azimuth_solid_earth_tides_applied
There was a problem hiding this comment.
It is not a bad idea. Just in case it will be more difficult to change the product
| Meta('static_troposphere_applied', bool(cfg.lut_params.enabled), | ||
| "If True, troposphere correction based on a static model has been applied"), |
There was a problem hiding this comment.
What is going to happen for static troposphere correction if cfg.lut_params.enabled is True, and we apply weather-model based troposphere correction? I think this field has to be False in that case?
There was a problem hiding this comment.
My hope is that when we include the individual enabling/disabling of the LUTs, each of these flags will be replaced by its own individual flag. So later on, we should have the ability to set to False (or True) each of these corrections
3 participants
This PR adds some metadata in CSLC-S1 product to indicate which correction has been applied.
Also corrects the snake VS camel case inconsistency in the name of the flattening flags.
Can you check if the description of the individual correction metadata looks clear?