Show validation suggestion for non-matching field pattern #11757
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds non-blocking inline validation feedback for text input fields that have a defined pattern. When a field value doesn't match its expected pattern, an informational message appears below the input to guide the user, while still allowing editing and saving.
Key changes:
- Introduced
updatePatternValidation()function to validate field values against regex patterns - Hooked validation into input, blur, and change events to provide real-time feedback
- Added CSS styling for the validation message display
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/ui/fields/input.js | Added pattern validation logic and integrated it into input event handlers; reformatted existing code for consistency |
| modules/ui/fields/textarea.js | Cleaned up blank lines for consistency |
| css/80_app.css | Added styling for the pattern validation info message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| i.tags = function (tags) { | ||
| _tags = tags; | ||
|
|
||
| const vals = getVals(tags); | ||
| const isMixed = vals.size > 1; | ||
| var val = vals.size === 1 ? ([...vals][0] ?? '') : ''; |
There was a problem hiding this comment.
The updatePatternValidation() function should be called at the end of i.tags() to ensure the validation state reflects the newly set tags. Currently, validation only updates on user input events, so programmatic tag updates won't trigger validation feedback.
This comment was marked as spam.
This comment was marked as spam.
|
It would be nice to have all the formatting changes in a separate commit. |
okay sir i will do |
I think sir i did already in separate commit |
|
based on your activity on this project I bet this is LLM-generated unreviewed content and therefore should be rejected without detailed review see #10769 
|
4 participants
Adds inline, informational validation feedback when a field value does not #10769
match the expected pattern. And one things I didn't add for website till now because for that i have to go from scratch so tell me should i move furthur or this is okay (elaborated in issues comment)
This is a suggestion only and does not block editing or saving.