After removing changes #11756
After removing changes #11756
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds inline, informational regex validation feedback to textarea fields, improving user experience by providing real-time format validation without blocking input. The changes also clean up formatting inconsistencies and leftover comments from the development process.
Key Changes:
- Implements pattern validation UI for textarea fields with visual feedback
- Adds validation check triggers on input, blur, and change events
- Removes comment-only and whitespace-only changes from earlier drafts
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/ui/fields/textarea.js | Adds pattern validation logic, UI feedback elements, and event handlers for real-time validation |
| modules/validations/crossing_ways.js | Restores closing brace that was previously deleted |
| css/30_highways.css | Fixes malformed CSS comment syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| enter | ||
| .append('span') | ||
| .attr('class', 'form-field-pattern-info-text') |
There was a problem hiding this comment.
The translation key 'inspector.invalid_format' is referenced but there's no indication in the PR that this translation string exists. Consider documenting where this key should be defined or adding a comment explaining the expected translation setup.
| .attr('class', 'form-field-pattern-info-text') | |
| .attr('class', 'form-field-pattern-info-text') | |
| // `inspector.invalid_format` is defined in the shared inspector translations |
| } from '../../util'; | ||
| import { uiLengthIndicator } from '..'; | ||
|
|
||
| import { svgIcon } from '../../svg/icon'; // ← ADDED |
There was a problem hiding this comment.
what is the point of // ← ADDED comments?
these should be removed
There was a problem hiding this comment.
(if this PR makes sense)
which specific problem is being fixed here? you link own PR, is it fixing problem in own PR? then fix and push fix there |
|
please see #11746 (comment) — this also duplicates your other PR #11757 |
3 participants
This pull request adds inline, informational regex validation to textarea fields to improve user feedback during editing. #11736
As part of review feedback, this update also removes leftover comment-only and whitespace-only changes introduced during drafting. The final diff is limited to functional and intentional changes only.
Summary
Adds inline informational feedback for regex-based validation in textarea fields
Improves clarity for users without blocking input
Removes temporary comments and formatting-only changes
No behavioral changes outside of validation feedback
Notes
Validation is informational only and does not prevent saving
No UI text or translation changes are introduced beyond the validation message