Skip to content

Reconsider use of never-stable, add techpreview variant #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Aug 31, 2021
Merged

Reconsider use of never-stable, add techpreview variant #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e710a
Adjust criteria for use of never-stable, add techpreview variants
stbenjam Aug 18, 2021
a7f9e53
Exclude never-stable/techpreview from the home page widgets
stbenjam Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 28 additions & 38 deletions pkg/testgridanalysis/testidentification/ocp_variants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ var (
rtRegex = regexp.MustCompile(`(?i)-rt`)
s390xRegex = regexp.MustCompile(`(?i)-s390x`)
serialRegex = regexp.MustCompile(`(?i)-serial`)
techpreview = regexp.MustCompile(`(?i)-techpreview`)
upgradeRegex = regexp.MustCompile(`(?i)-upgrade`)
// some vsphere jobs do not have a trailing -version segment
vsphereRegex = regexp.MustCompile(`(?i)-vsphere`)
Expand All @@ -58,64 +59,46 @@ var (
"realtime",
"s390x",
"serial",
"techpreview",
"upgrade",
"vsphere-ipi",
"vsphere-upi",
"single-node",
)

// openshiftJobsNeverStableForVariants is a list of jobs that are
// below 40% passing rate. As we phase these jobs in, they should be
// excluded from "normal" variants and once they are passing above 40%
// can "graduated" from never-stable.
// openshiftJobsNeverStableForVariants is a list of unproven new jobs or
// jobs that are near permafail (i.e. < 40%) for an extended period of time.
// They are excluded from "normal" variants and once they are passing above
// 40% can "graduated" from never-stable.
//
// Jobs should have a linked BZ before being added to this list.
//
// These jobs are still listed as jobs in total and when individual
// tests fail, they will still be listed with these jobs as causes.
openshiftJobsNeverStableForVariants = sets.NewString(
// Experimental jobs that are under active development
"periodic-ci-openshift-release-master-ci-4.9-e2e-aws-hypershift",
"periodic-ci-openshift-release-master-ci-4.9-e2e-aws-ovn",
"periodic-ci-openshift-release-master-ci-4.9-e2e-aws-upgrade-single-node",
"periodic-ci-openshift-release-master-ci-4.9-e2e-gcp-ovn",
"periodic-ci-openshift-release-master-ci-4.9-e2e-openstack-ovn",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade-rollback",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-aws-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-aws-upgrade-rollback",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-azure-ovn-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-gcp-ovn-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-openstack-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-from-stable-4.7-e2e-aws-upgrade",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-arm64",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-csi-migration",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-proxy",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-workers-rhel7",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-ovn-dualstack",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-ovn-dualstack-local-gateway",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-ovn-ipv6",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-remote-libvirt-ppc64le",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-remote-libvirt-s390x",
"periodic-ci-openshift-release-master-nightly-4.9-openshift-ipi-azure-arcconformance",
"periodic-ci-openshift-release-master-nightly-4.9-upgrade-from-stable-4.7-e2e-aws-upgrade-paused",
"periodic-ci-openshift-release-master-nightly-4.9-upgrade-from-stable-4.8-e2e-aws-upgrade",
"release-openshift-ocp-installer-e2e-azure-ovn-4.9",
"release-openshift-ocp-installer-e2e-gcp-ovn-4.9",

// https://issues.redhat.com/browse/OSD-8071
"release-openshift-ocp-osd-aws-nightly-4.9",
"release-openshift-ocp-osd-gcp-nightly-4.9",
"release-openshift-origin-installer-e2e-aws-disruptive-4.9",
"release-openshift-origin-installer-e2e-aws-sdn-network-stress-4.9",
"release-openshift-origin-installer-e2e-aws-upgrade-4.6-to-4.7-to-4.8-to-4.9-ci",
"release-openshift-origin-installer-old-rhcos-e2e-aws-4.9",

// Compact jobs alerting on etcdGRPCRequestsSlow
// BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1986119
// https://bugzilla.redhat.com/show_bug.cgi?id=1979966
"periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-workers-rhel7",

// https://bugzilla.redhat.com/show_bug.cgi?id=1997345
"periodic-ci-openshift-multiarch-master-nightly-4.9-ocp-e2e-remote-libvirt-ppc64le",
"periodic-ci-openshift-multiarch-master-nightly-4.9-ocp-e2e-compact-remote-libvirt-ppc64le",

// https://bugzilla.redhat.com/show_bug.cgi?id=1979962
"periodic-ci-openshift-release-master-ci-4.9-e2e-aws-compact",
"periodic-ci-openshift-release-master-ci-4.9-e2e-aws-compact-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-e2e-azure-compact",
"periodic-ci-openshift-release-master-ci-4.9-e2e-azure-compact-upgrade",
"periodic-ci-openshift-release-master-ci-4.9-e2e-gcp-compact",
"periodic-ci-openshift-release-master-ci-4.9-e2e-gcp-compact-upgrade",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-compact-remote-libvirt-ppc64le",
"periodic-ci-openshift-release-master-nightly-4.9-e2e-compact-remote-libvirt-s390x",
"release-openshift-ocp-installer-e2e-metal-compact-4.9",
"release-openshift-origin-installer-e2e-aws-sdn-network-stress-4.9",
)
)

Expand All @@ -140,10 +123,16 @@ func (v openshiftVariants) IdentifyVariants(jobName string) []string {
}
}()

// If a job is in never-stable, it is excluded from other possible variant aggregations
if v.IsJobNeverStable(jobName) {
return []string{"never-stable"}
}

// Tech preview jobs are excluded from other possible variant aggregations
if techpreview.MatchString(jobName) {
return []string{"techpreview"}
}

// if it's a promotion job, it can't be a part of any other variant aggregation
if promoteRegex.MatchString(jobName) {
variants = append(variants, "promote")
Expand All @@ -156,6 +145,7 @@ func (v openshiftVariants) IdentifyVariants(jobName string) []string {
if azureRegex.MatchString(jobName) {
variants = append(variants, "azure")
}

if compactRegex.MatchString(jobName) {
variants = append(variants, "compact")
}
Expand Down
152 changes: 128 additions & 24 deletions ...g/__recordings__/TestAnalysis_2684695171/should-render-correctly_3267003315/recording.har
View file
Open in desktop

Large diffs are not rendered by default.

Loading