Skip to content

Bug 1782997: Build natively on all arches #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Dec 17, 2019
Merged

Bug 1782997: Build natively on all arches #29

openshift-merge-robot merged 2 commits into from
Dec 17, 2019

Conversation

@openshift-cherrypick-robot
Copy link
Contributor

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 17, 2019

This is an automated cherry-pick of #26

/assign crawford

yselkowitz and others added 2 commits December 17, 2019 03:06
@yselkowitz
Build natively on all arches
ef08d38 
Specifying -x86_64-linux-gnu in the make target causes GOARCH=amd64 to
be defined, resulting in exec format errors when built on other arches.
@clnperez
auto-detect build runtime arch
0075676 
If the user hasn't explictyly set GOARCH, don't default to amd64. This
way, a user has to expliciltly cross-compile, instead of needing to know
to set GOARCH on build for a native arch that isn't amd64.

operator-framework/operator-sdk#2268

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 17, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782996, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1782996 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1782996: Build natively on all arches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2019
@yselkowitz
Copy link
Contributor

yselkowitz commented Dec 17, 2019

/retitle [release-4.3] Bug 1782997: Build natively on all arches

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2019

@yselkowitz: Re-titling can only be requested by trusted users, like repository collaborators.

Details

In response to this:

/retitle [release-4.3] Bug 1782997: Build natively on all arches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link
Contributor

yselkowitz commented Dec 17, 2019

/assign @joelanford

@crawford
Copy link

crawford commented Dec 17, 2019

/retitle Bug 1782997: Build natively on all arches

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1782996: Build natively on all arches Bug 1782997: Build natively on all arches Dec 17, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782997, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1782997: Build natively on all arches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 17, 2019
@crawford
Copy link

crawford commented Dec 17, 2019

/retest

@yselkowitz
Copy link
Contributor

yselkowitz commented Dec 17, 2019

CI blocked by #30.

@yselkowitz
Copy link
Contributor

yselkowitz commented Dec 17, 2019

/retest
#30 has now been merged.

@crawford
Copy link

crawford commented Dec 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: crawford, openshift-cherrypick-robot
To complete the pull request process, please assign joelanford
You can assign the PR to them by writing /assign @joelanford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 53536a1 into openshift:release-4.3 Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2019

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1782997 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1782997: Build natively on all arches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford
Copy link

crawford commented Dec 18, 2019

/cherry-pick release-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2019
Merged
@openshift-cherrypick-robot
Copy link
Contributor Author

openshift-cherrypick-robot commented Dec 18, 2019

@crawford: new pull request created: #31

Details

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

Assignees

@crawford crawford

@joelanford joelanford

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @yselkowitz @crawford @joelanford @openshift-merge-robot @clnperez