Bug 1782996: Build natively on all arches #26
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @yselkowitz. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
/cherry-pick release-4.3 |
|
@yselkowitz: only openshift org members may request cherry-picks. You can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1782996: Build natively on all arches |
|
@yselkowitz: Re-titling can only be requested by trusted users, like repository collaborators. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yselkowitz
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@yselkowitz: This pull request references Bugzilla bug 1782996, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Shouldn't someone be able to retitle their own PR? |
Does GitHub not give you a direct edit button for your own PR? Shouldn't have to use the bot. |
|
/lgtm |
|
@crawford: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/retest |
|
/test images |
|
/retest |
|
Test errors should be fixed by #28. /retest |
Specifying -x86_64-linux-gnu in the make target causes GOARCH=amd64 to be defined, resulting in exec format errors when built on other arches.
If the user hasn't explictyly set GOARCH, don't default to amd64. This way, a user has to expliciltly cross-compile, instead of needing to know to set GOARCH on build for a native arch that isn't amd64. operator-framework/operator-sdk#2268 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
|
Added the patch from operator-framework/operator-sdk#2268 (minus the Changelog entry which didn't apply cleanly) so that operator-sdk itself will build with the native arch. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, joelanford, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@yselkowitz: All pull requests linked via external trackers have merged. Bugzilla bug 1782996 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@crawford: new pull request created: #29 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 participants
Specifying -x86_64-linux-gnu in the make target causes GOARCH=amd64 to
be defined, resulting in exec format errors when built on other arches.
CC: @crawford