[OCPNODE-673] Add kubeletconfig to bootstrap mode #2547

QiWang19 · 2021-04-26T20:32:54Z

Follow up PR for https://github.com/openshift/machine-config-operator/pull/2517/files#r611658650
To run KubeletConfig at bootstrap mode.

https://issues.redhat.com/browse/OCPNODE-673

Signed-off-by: Qi Wang qiwan@redhat.com

- What I did

- How to verify it

- Description for the changelog

openshift-ci-robot · 2021-04-26T20:33:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

QiWang19 · 2021-06-23T16:34:49Z

/retest

QiWang19 · 2021-06-24T16:12:49Z

/assign @yuqi-zhang

QiWang19 · 2021-06-27T05:06:56Z

/retest

QiWang19 · 2021-06-29T04:48:17Z

/retest

QiWang19 · 2021-06-30T15:07:33Z

/retest

QiWang19 · 2021-06-30T15:08:18Z

@kikisdeliveryservice PTAL

pkg/controller/kubelet-config/kubelet_config_controller.go

kikisdeliveryservice · 2021-06-30T19:47:21Z

PR seems to be consistenly failing e2e, have you investigated @QiWang19

kikisdeliveryservice

throughout can we name this bootstrap config instead of original config which is already used post bootsrap?

pkg/controller/kubelet-config/kubelet_config_controller.go

openshift-ci · 2021-10-20T21:26:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, rphillips, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-10-20T21:50:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-20T22:26:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-20T22:38:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-20T22:50:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-20T23:02:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-20T23:14:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-20T23:26:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-20T23:51:50Z

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws	`a282006`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-gcp-op-single-node	`a282006`	link	false	`/test e2e-gcp-op-single-node`
ci/prow/e2e-aws-workers-rhel7	`a282006`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-workers-rhel8	`a282006`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-metal-ipi	`a282006`	link	false	`/test e2e-metal-ipi`
ci/prow/e2e-aws-disruptive	`a282006`	link	false	`/test e2e-aws-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-10-21T00:03:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T00:15:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T00:27:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T00:39:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T00:51:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T01:03:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T01:27:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T01:51:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T02:03:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T02:15:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T02:27:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T02:39:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T02:51:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T03:03:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T03:16:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T03:42:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-21T03:55:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from kikisdeliveryservice and sinnykumari April 26, 2021 20:33

kikisdeliveryservice changed the title ~~Add kubeletconfig to bootstrap mode~~ [WIP] Add kubeletconfig to bootstrap mode Apr 27, 2021

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2021

QiWang19 changed the title ~~[WIP] Add kubeletconfig to bootstrap mode~~ Add kubeletconfig to bootstrap mode Apr 28, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2021

kikisdeliveryservice requested review from umohnani8 and removed request for sinnykumari May 24, 2021 23:51

QiWang19 force-pushed the kubecfg-boot branch 8 times, most recently from 91d4a95 to c44331c Compare June 22, 2021 23:27

QiWang19 force-pushed the kubecfg-boot branch from c44331c to b30f146 Compare June 23, 2021 18:50

openshift-ci bot assigned yuqi-zhang Jun 24, 2021

rphillips reviewed Jun 30, 2021

View reviewed changes

pkg/controller/kubelet-config/kubelet_config_controller.go Outdated Show resolved Hide resolved

QiWang19 force-pushed the kubecfg-boot branch from b30f146 to e8fd2b8 Compare June 30, 2021 17:41

kikisdeliveryservice unassigned yuqi-zhang Jun 30, 2021

kikisdeliveryservice previously requested changes Jun 30, 2021

View reviewed changes

pkg/controller/kubelet-config/kubelet_config_controller.go Outdated Show resolved Hide resolved

pkg/controller/kubelet-config/kubelet_config_controller.go Outdated Show resolved Hide resolved

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021

openshift-merge-robot merged commit 7615a61 into openshift:master Oct 21, 2021

harche mentioned this pull request Oct 20, 2022

OCPBUGS-2079: Add ephemeral storage to kubelet system reserved args #3375

Merged

jcanocan mentioned this pull request Aug 31, 2023

WIP: Add KubeVirt rate limiting profile kubelet kubevirt/hyperconverged-cluster-operator#2496

Closed

11 tasks

[OCPNODE-673] Add kubeletconfig to bootstrap mode #2547

[OCPNODE-673] Add kubeletconfig to bootstrap mode #2547

Uh oh!

Conversation

QiWang19 commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 26, 2021

Uh oh!

QiWang19 commented Jun 23, 2021

Uh oh!

QiWang19 commented Jun 24, 2021

Uh oh!

QiWang19 commented Jun 27, 2021

Uh oh!

QiWang19 commented Jun 29, 2021

Uh oh!

QiWang19 commented Jun 30, 2021

Uh oh!

QiWang19 commented Jun 30, 2021

Uh oh!

Uh oh!

kikisdeliveryservice commented Jun 30, 2021

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-bot commented Oct 20, 2021

Uh oh!

openshift-ci bot commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

openshift-bot commented Oct 21, 2021

Uh oh!

QiWang19 commented Apr 26, 2021 •

edited

Loading

openshift-ci bot commented Oct 20, 2021 •

edited

Loading