OCPCLOUD-2010: Add external platform type support in IsCloudProviderExternal

[adriengentil]

This change enables the external platform when external platform type is
set, when cloud controller manager mode is set to External, and when the
feature FeatureGateExternalCloudProviderExternal is enabled.

PR on API side: openshift/api#1434

[openshift-ci-robot]

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

This change enables the external platform when external platform type is
set and when cloud controller manager mode is set to External.

Since cloud controller manager mode is controlled from the
PlatformSpec struct, I had to change the signature of
IsCloudProviderExternal to take the Infrastructure struct in
parameter.

PR on API side: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[adriengentil]

/cc @elmiko

[elmiko]

i think this generally looks good, i'd like to talk with @JoelSpeed about changing the way that IsCloudProviderExternal works, and if we should persist some of the external platform information into the status field.

[JoelSpeed]

Changing signatures is fun, have we searched through OpenShift to see how many usages there are of this function? I know of at least CCMO, KCMO, KASO and MCO usage, how many other places will need fixing?

[adriengentil]

Changing signatures is fun, have we searched through OpenShift to see how many usages there are of this function? I know of at least CCMO, KCMO, KASO and MCO usage, how many other places will need fixing?

I see usages in MCO, KCMO and CCMO:
https://github.com/search?q=org%3Aopenshift+IsCloudProviderExternal+NOT+repo%3Aopenshift%2Flibrary-go+language%3AGo&type=Code&l=Go

at least for these ones, we need to re-vendor library-go them as part of the task. I don't it used in KASO.

[openshift-ci-robot]

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

This change enables the external platform when external platform type is
set and when cloud controller manager mode is set to External.

PR on API side: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adriengentil]

I have updated the PR which takes my latest update from openshift/api#1434 that adds the CCM state in the PlatformStatus object.

[elmiko]

this is looking good to me
/lgtm

[elmiko]

oops, just noticed it's in draft

[elmiko]

/lgtm

[openshift-ci-robot]

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

Details

In response to this:

This change enables the external platform when external platform type is
set, when cloud controller manager mode is set to External, and when the
feature FeatureGateExternalCloudProviderExternal is enabled.

PR on API side: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

uh oh, looks like an issue with the unit test

/lgtm cancel

[adriengentil]

Looks like the error in the unit test is unrelated to my change 🤔

{  set -o pipefail; go test  -race -json ./pkg/... | gotest2junit > /logs/artifacts/junit_report.xml
SKIP: github.com/openshift/library-go/pkg/operator/loglevel TestClusterOperatorLoggingController
make: *** [vendor/github.com/openshift/build-machinery-go/make/targets/golang/test-unit.mk:12: test-unit] Error 1

[elmiko]

ack, thanks @adriengentil , i will check back in a bit, going to grab some food

[adriengentil]

/retest
maybe it's just a flake?

[adriengentil]

/retest

[elmiko]

/lgtm

[soltysh]

One nit and you're good to go

[soltysh]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, elmiko, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.