-
Notifications
You must be signed in to change notification settings - Fork 74
OCPCLOUD-2010: Re-vendor api and library-go for external platform support #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2010: Re-vendor api and library-go for external platform support #253
Conversation
|
@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
|
Pinned Should be solved once #252 is merged. |
ee3d807 to
df38ebd
Compare
elmiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just waiting on the upstream PRs so we can revendor
…port Revendor openshift/api and openshift/library-go in order to support the external platform type. library-go PR: openshift/library-go#1496 API PR: openshift/api#1434
df38ebd to
1599796
Compare
|
/lgtm let's see how the e2e tests turn out to make sure we aren't breaking anything |
|
@adriengentil: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
in two of the cases it looks like there is some csi driver related issue, and the other case is about a failed node. i don't think these are related to this change. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Revendor openshift/api and openshift/library-go in order to support the
external platform type.
library-go PR: openshift/library-go#1496
API PR: openshift/api#1434