Skip to content

[release-4.19] OCPBUGS-78457: Explicitly set the ReadOnlyRootFilesystem flag to false #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
Apr 1, 2026
Merged

[release-4.19] OCPBUGS-78457: Explicitly set the ReadOnlyRootFilesystem flag to false #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2666bd
Explicitly set ReadOnlyRootFilesystem to false for machine-os-images …
hroyrh Feb 5, 2026
bf1ae6c
Explicitly set the ReadOnlyRootFilesystem flag to false
hroyrh Feb 18, 2026
d9073c7
Older ocp releases use pointer library, update manifests
hroyrh Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/bindata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions provisioning/baremetal_pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ func createInitContainerMachineOsDownloader(info *ProvisioningInfo, imageURLs st
Command: []string{command},
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand All @@ -313,6 +314,7 @@ func createInitContainerStaticIpSet(images *Images, config *metal3iov1alpha1.Pro
Command: []string{"/set-static-ip"},
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
Add: []corev1.Capability{"NET_ADMIN"},
Expand Down Expand Up @@ -396,6 +398,7 @@ func createContainerMetal3Dnsmasq(images *Images, config *metal3iov1alpha1.Provi
Image: images.Ironic,
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down Expand Up @@ -470,6 +473,7 @@ func createContainerMetal3Httpd(images *Images, config *metal3iov1alpha1.Provisi
Image: images.Ironic,
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down Expand Up @@ -526,6 +530,7 @@ func createContainerMetal3Ironic(images *Images, info *ProvisioningInfo, config
Image: images.Ironic,
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down Expand Up @@ -586,6 +591,7 @@ func createContainerMetal3RamdiskLogs(images *Images) corev1.Container {
},
TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
Add: []corev1.Capability{
Expand All @@ -604,6 +610,7 @@ func createContainerMetal3StaticIpManager(images *Images, config *metal3iov1alph
Command: []string{"/refresh-static-ip"},
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for mounting /proc to set the addr_gen_mode
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down
3 changes: 3 additions & 0 deletions provisioning/bmo_pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ func createContainerBaremetalOperator(info *ProvisioningInfo) (corev1.Container,
"-retry-period-seconds", "26",
},
ImagePullPolicy: "IfNotPresent",
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
},
VolumeMounts: []corev1.VolumeMount{
ironicCredentialsMount,
ironicTlsMount,
Expand Down
1 change: 1 addition & 0 deletions provisioning/image_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func createContainerImageCache(images *Images) corev1.Container {
Image: images.Ironic,
ImagePullPolicy: corev1.PullIfNotPresent,
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down
1 change: 1 addition & 0 deletions provisioning/image_customization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func createImageCustomizationContainer(images *Images, info *ProvisioningInfo, i
// TODO: This container does not have to run in privileged mode when the i-c-c has
// its own volume and does not have to use the imageCacheSharedVolume
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down
1 change: 1 addition & 0 deletions provisioning/ironic_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func createContainerIronicProxy(ironicIP string, images *Images) corev1.Containe
Image: images.Ironic,
ImagePullPolicy: corev1.PullIfNotPresent,
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
Add: []corev1.Capability{"FOWNER"},
Expand Down
1 change: 1 addition & 0 deletions provisioning/machine_os_images.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func createInitContainerMachineOSImages(info *ProvisioningInfo, whichImages stri
},
},
SecurityContext: &corev1.SecurityContext{
ReadOnlyRootFilesystem: pointer.BoolPtr(false),
// Needed for hostPath image volume mount
Privileged: pointer.BoolPtr(true),
Capabilities: &corev1.Capabilities{
Expand Down