[release-4.19] OCPBUGS-78457: Explicitly set the ReadOnlyRootFilesystem flag to false by hroyrh · Pull Request #574 · openshift/cluster-baremetal-operator

hroyrh · 2026-03-13T09:38:30Z

No description provided.

…so that SCC during deployment cannot override it Signed-off-by: Himanshu Roy <hroy@redhat.com> (cherry picked from commit 6ef8811)

The support for ReadOnlyRootFilesystem was only introduced in 4.21, and in ocp 4.20 and earlier, it's not set explicitly which defaults it to false. But, SCCs during deployment of ocp 4.20 led to setting this flag to true, which causes failures during deployment. Therefore, setting it explicitly so it doesn't get overwritten. Signed-off-by: Himanshu Roy <hroy@redhat.com> (cherry picked from commit 9d73ca2)

openshift-ci-robot · 2026-03-13T09:38:36Z

@hroyrh: This pull request references Jira Issue OCPBUGS-78457, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-13T09:38:42Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07877242-fee7-4d2f-957d-fe4425e00ec0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

hroyrh · 2026-03-13T10:13:31Z

/jira refresh

openshift-ci-robot · 2026-03-13T10:13:40Z

@hroyrh: This pull request references Jira Issue OCPBUGS-78457, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-76340 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-76340 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hroyrh · 2026-03-13T10:14:53Z

/cherrypick release-4.18

openshift-cherrypick-robot · 2026-03-13T10:14:58Z

@hroyrh: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hroyrh · 2026-03-13T10:45:55Z

/retest-required

hroyrh · 2026-03-14T04:05:09Z

/retest-required

MahnoorAsghar · 2026-03-17T13:10:28Z

/test unit

hroyrh · 2026-03-27T10:28:43Z

/retest-required

openshift-ci · 2026-03-27T10:33:29Z

@hroyrh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

iurygregory · 2026-03-27T13:16:47Z

/lgtm

dtantsur · 2026-03-30T07:16:27Z

/approve
/label backport-risk-assessed

openshift-ci · 2026-03-30T07:18:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, hroyrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sgoveas · 2026-03-31T12:06:48Z

/verified by sgoveas link

openshift-ci-robot · 2026-03-31T12:07:01Z

@sgoveas: This PR has been marked as verified by sgoveas [link](https://redhat.atlassian.net/browse/OCPBUGS-78457?focusedCommentId=16584571).

Details

In response to this:

/verified by sgoveas link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hroyrh added 3 commits March 13, 2026 15:00

Explicitly set ReadOnlyRootFilesystem to false for machine-os-images …

c2666bd

…so that SCC during deployment cannot override it Signed-off-by: Himanshu Roy <hroy@redhat.com> (cherry picked from commit 6ef8811)

Older ocp releases use pointer library, update manifests

d9073c7

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2026

openshift-ci bot requested review from andfasano and sadasu March 13, 2026 09:40

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2026

openshift-ci bot requested a review from jadhaj March 13, 2026 10:13

openshift-ci bot assigned iurygregory Mar 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026

sgoveas added a commit to sgoveas/release that referenced this pull request Mar 27, 2026

test openshift/cluster-baremetal-operator#574

6baa0af

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 30, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026

sgoveas added a commit to sgoveas/release that referenced this pull request Mar 30, 2026

test openshift/cluster-baremetal-operator#574

e9eeb76

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 31, 2026

Conversation

hroyrh commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

coderabbitai bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

hroyrh commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

hroyrh commented Mar 13, 2026

Uh oh!

openshift-cherrypick-robot commented Mar 13, 2026

Uh oh!

hroyrh commented Mar 13, 2026

Uh oh!

hroyrh commented Mar 14, 2026

Uh oh!

MahnoorAsghar commented Mar 17, 2026

Uh oh!

hroyrh commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 27, 2026

Uh oh!

iurygregory commented Mar 27, 2026

Uh oh!

dtantsur commented Mar 30, 2026

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

sgoveas commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coderabbitai bot commented Mar 13, 2026 •

edited

Loading