Skip to content

Use SdkClient for persistence in TransportGetMonitorAction#2053

Merged
AWSHurneyt merged 2 commits intoopensearch-project:remote-metadata-supportfrom
manaswini1920:feature/sdk-persistence-refactor
Mar 26, 2026
Merged

Use SdkClient for persistence in TransportGetMonitorAction#2053
AWSHurneyt merged 2 commits intoopensearch-project:remote-metadata-supportfrom
manaswini1920:feature/sdk-persistence-refactor

Conversation

@manaswini1920
Copy link
Contributor

@manaswini1920 manaswini1920 commented Mar 25, 2026

Description

Replace direct client.get() with sdkClient.getDataObjectAsync() for monitor retrieval.
SDK handles local vs remote routing internally based on remote_metadata_type setting.
Follows the same pattern as ML Commons (TransportRegisterAgentAction).

Reference: https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/action/agents/TransportRegisterAgentAction.java

  • Add TENANT_ID_HEADER constant to AlertingPlugin
  • Use sdkClient for all persistence (no dual-path branching)
  • Extract tenantId from request header, pass to SDK
  • Add 3 unit tests

Related Issues

Depends on #2047, #2052

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

@riysaxen-amzn riysaxen-amzn self-requested a review March 25, 2026 19:35
@manaswini1920 manaswini1920 force-pushed the feature/sdk-persistence-refactor branch from 5656563 to 8d4bb0c Compare March 25, 2026 19:59
@manaswini1920 manaswini1920 changed the title feat(alerting): Refactor TransportGetMonitorAction to use SDK in remo… Use SdkClient for persistence in TransportGetMonitorAction Mar 25, 2026
@manaswini1920 manaswini1920 changed the base branch from main to remote-metadata-support March 25, 2026 22:10
Replace direct client.get() with sdkClient.getDataObjectAsync() for
monitor retrieval. SDK handles local vs remote routing internally.
Follows ML Commons pattern (TransportRegisterAgentAction).

Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
@manaswini1920 manaswini1920 force-pushed the feature/sdk-persistence-refactor branch from 8d4bb0c to 95a7bbe Compare March 26, 2026 05:27
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
@AWSHurneyt AWSHurneyt merged commit 9858daa into opensearch-project:remote-metadata-support Mar 26, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants