Use SdkClient for persistence in 4 transport actions#2060
Open
manaswini1920 wants to merge 1 commit intoopensearch-project:remote-metadata-supportfrom
Open
Use SdkClient for persistence in 4 transport actions#2060manaswini1920 wants to merge 1 commit intoopensearch-project:remote-metadata-supportfrom
manaswini1920 wants to merge 1 commit intoopensearch-project:remote-metadata-supportfrom
Conversation
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
manaswini1920
force-pushed
the
feature/sdk-persistence-batch2
branch
2 times, most recently
from
033be42 to
64ca2df
Compare
eirsep
reviewed
Mar 26, 2026
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportDeleteMonitorAction.kt
Show resolved
Hide resolved
…ons, SearchComments Replace direct client.get/search calls with sdkClient equivalents: - TransportDeleteMonitorAction: sdkClient.getDataObject() in getMonitor() - TransportSearchMonitorAction: sdkClient.searchDataObjectAsync() in search() - TransportGetDestinationsAction: sdkClient.searchDataObjectAsync() in search() - TransportSearchAlertingCommentAction: sdkClient.searchDataObjectAsync() in search() Walk full cause chain for IndexNotFoundException handling. Add unit tests for SearchMonitor and GetDestinations SDK paths. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
force-pushed
the
feature/sdk-persistence-batch2
branch
from
64ca2df to
ec7c4c7
Compare
2 tasks
eirsep
reviewed
Mar 26, 2026
| actionListener.onFailure( | ||
| AlertingException.wrap( | ||
| OpenSearchStatusException("Monitor with $monitorId is not found", RestStatus.NOT_FOUND) | ||
| ) |
eirsep
reviewed
Mar 26, 2026
Member
eirsep
left a comment
eirsep
left a comment
There was a problem hiding this comment.
we need to ensure we finish loop after listener.onResponse/Failure statements.
and transversely we need to make sure listener.onResponse/Failure statements. is present everywhere
we have had a lot of pain with this in past ... plz add unit tests with 100% coverage for action classes.
rest changes are LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use SdkClient for persistence in 4 transport actions:
Walk full cause chain for IndexNotFoundException handling.
Add unit tests for SearchMonitor and GetDestinations SDK paths.
Related Issues
Follows pattern from #2053
Check List
--signoff.