Skip to content

REPORT-495: Added an onkeyup event to the Widgets and Text input elem… #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IamMujuziMoses wants to merge 1 commit into
base: master
Choose a base branch
from
Open

REPORT-495: Added an onkeyup event to the Widgets and Text input elem… #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
language: java
jdk:
- oraclejdk8
- openjdk8

4 changes: 4 additions & 0 deletions omod/src/main/java/org/openmrs/module/htmlwidgets/web/html/DateWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ public class DateWidget implements Widget {
/**
* @see Widget#render(WidgetConfig)
*/
@Override
public void render(WidgetConfig config, Writer w) throws IOException {

HtmlUtil.renderResource(w, config.getRequest(), "/scripts/calendar/calendar.js");

Object idPrefix = config.getId();
Copy link
Copy Markdown

@Adeegithub Adeegithub Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does config.getId() always return an Object? Double check this please!

config.setFixedAttribute("onchange", "disableButtons('" + idPrefix + "')");
config.setFixedAttribute("onkeyup", "disableButtons('" + idPrefix + "')");
config.setFixedAttribute("size", "10");
config.setFixedAttribute("onClick", "showCalendar(this);");

Expand Down
4 changes: 4 additions & 0 deletions omod/src/main/java/org/openmrs/module/htmlwidgets/web/html/TextAreaWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ public class TextAreaWidget implements Widget {
/**
* @see Widget#render(WidgetConfig)
*/
@Override
public void render(WidgetConfig config, Writer w) throws IOException {

Object idPrefix = config.getId();
Copy link
Copy Markdown

@Adeegithub Adeegithub Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. Double check the data type!

config.setFixedAttribute("onkeyup", "disableButtons('" + idPrefix + "')");
config.setDefaultAttribute("cols", "20");
config.setDefaultAttribute("rows", "2");
HtmlUtil.renderOpenTag(w, "textarea", config.getAttributes());
Expand Down
4 changes: 4 additions & 0 deletions omod/src/main/java/org/openmrs/module/htmlwidgets/web/html/TextWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ public class TextWidget implements Widget {
/**
* @see Widget#render(WidgetConfig)
*/
@Override
public void render(WidgetConfig config, Writer w) throws IOException {

Object idPrefix = config.getId();
config.setFixedAttribute("onkeyup", "disableButtons('" + idPrefix + "')");
String textValue = config.getDefaultValue() == null ? "" : config.getDefaultValue().toString();
config.setFixedAttribute("type", "text");
config.setDefaultAttribute("value", textValue);
Expand Down