REPORT-495: Added an onkeyup event to the Widgets and Text input elem…#8
Open
IamMujuziMoses wants to merge 1 commit intoopenmrs:masterfrom
Open
REPORT-495: Added an onkeyup event to the Widgets and Text input elem…#8IamMujuziMoses wants to merge 1 commit intoopenmrs:masterfrom
IamMujuziMoses wants to merge 1 commit intoopenmrs:masterfrom
Conversation
Author
|
@davidpalacios @dkayiwa requesting review on this |
Member
|
@IamMujuziMoses on the JIRA ticket, can you attach screenshots with the effects of your changes, as advised at? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
…ents which disables and enables the smallButtons when the input elements have or don't have input respectively
IamMujuziMoses
force-pushed
the
REPORT-495
branch
from
1f48729 to
fa5476c
Compare
Adeegithub
reviewed
Mar 23, 2026
|
|
||
| HtmlUtil.renderResource(w, config.getRequest(), "/scripts/calendar/calendar.js"); | ||
|
|
||
| Object idPrefix = config.getId(); |
There was a problem hiding this comment.
Does config.getId() always return an Object? Double check this please!
| @Override | ||
| public void render(WidgetConfig config, Writer w) throws IOException { | ||
|
|
||
| Object idPrefix = config.getId(); |
There was a problem hiding this comment.
Same comment as above. Double check the data type!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ents which disables and enables the smallButtons when the input elements have or don't have input respectively
https://issues.openmrs.org/browse/REPORT-495