-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add a new Triage Onboarding issue type #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Triage Onboarding looks great. I think we could drop the Squad, Start Date, User Squad, and maybe even Urgency fields? It could also be good to add a field asking for their CC nomination thread, as that would tell us all the types of access they need.
27babca to
0df383d
Compare
|
Thanks, I've dropped the Squad, Start Data, and Urgency fields since Squad can be handled in the special requests section. All other request types have Urgency, so I'm not sure how people will feel about dropping that, but it is both kind of implicit in the type of request and there is a safety valve in the special requests section if need be. There was already a CC Thread field. |
|
Sounds good w.r.t. Urgency. Looks like Squad is still there, though? I would also recommend adding a Special Requests section to the Triage onboarding as well so that triage folks can ask to be on additional read-only teams. |
- Remove Squad from CC onboarding - Remove Urgency from Triage onboarding - Add Special Requests to Triage onboarding
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
| - type: input | ||
| id: ccthread | ||
| attributes: | ||
| label: Core Contributor nomination thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add validations: required: true to this since now this is a CC Onboarding specific template.
Uh oh!
There was an error while loading. Please reload this page.