cherry pick user contribution and typo fix#132
Merged
abhilashshetty04 merged 3 commits intodevelopfrom Jun 2, 2025
Merged
Conversation
Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix/ update expression in jsonnet dir Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix/ implement count by() on the right side of the expression The count by() returns one series per claim. This makes the join key unique on both sides. Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix/ simplify and fix the expression here introduce count by() to allow for unique join keys Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix: add namespace to PVC joins Avoid many-to-many errors when the same PVC name exists in multiple namespaces by joining on namespace. Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
dsharma-dc
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.